search

code4lib / shortimer

a webapp for code4lib jobs
http://jobs.code4lib.org
40 stars 15 forks source link

Descriptions not editable? #36

Closed jstirnaman closed 10 years ago

jstirnaman commented 10 years ago

I curated some jobs for the first time, but didn't see an option to edit the description. http://jobs.code4lib.org/curate/ says that curators should "make sure that the posting contains a significant amount of the origin text of the announcement." Do I just not have permission or am I missing something?

edsu commented 10 years ago

Ah there was a bug in views.py that was preventing people from editing unpublished jobs.

The intent was to allow any logged in user to edit job descriptions that have not yet been published. But once a job has been published only the user who created it (or designated staff) can edit the description.

The logic for determining if the job was published or not was wrong, so only staff or the creator of the job could edit descriptions. I've just deployed what I think is a fix to the problem. Can you try with another job in the queue and see if you can edit the description?

edsu commented 10 years ago

Also, thanks for the taking the time to curate some of the jobs!

jstirnaman commented 10 years ago

Behaves as expected. Quick work there, edsu!

edsu commented 10 years ago

@jstirnaman if you end up enjoying curating let me know and I'll add you as staff.