search

code4recovery / 12-step-meeting-list-feedback-enhancement

12 Step Meeting List plugin add-on which enhances the feedback feature found on the meetings detail page.
1 stars 1 forks source link

[Bug]: Plugin Delete Failure #33

Open kiyote33 opened 1 week ago

kiyote33 commented 1 week ago

Contact Details

waynep@code4recovery.org

Website With Issue

Any site where both the 12 Step Meeting List and the related Feedback Enhancement plugin are installed

What happened?

Deactivate the 12 Step Meeting List and then click the Delete link. A red failure alert message (see below) informs us that the deletion has failed. This is confirmed by a visual inspection of the plugins directory where the files are still present and viewing the Admin menu where the Meeting sub menu shows the list of meetings available to edit.

Clicking the Delete link a 2nd time causes the Delete to succeed. Visual inspection confirms the 12 Step Meeting List files are no longer in the plugins file folders as well as the Meetings admin menu item is no longer visible.

Further investigation shows that the Data Sources key/values in the MySQL database options table is still available (see bottom image), where it should have been removed like the meetings/location/groups information which is gone from the tables where that data is stored.

image image

What browsers are you seeing the problem on?

Firefox, Chrome, Microsoft Edge

Relevant log output/errors

No response

kiyote33 commented 1 week ago

Moved this issue from the 12 Step Meeting List repository to here in the Feedback Enhancement repository as it was found that deactivating the Feedback Enhancement and deleting the plugin allowed TSML to be removed without the warning issues. Note: when I rolled the 12 Step Meeting List back to version 3.14.30 the above reported problem disappeared. My conclusion is that the refactoring of the 12 Step Meeting List uninstall.php code is somehow conflicting with the Feedback Enhancement code.