search

code4recovery / pdf

Meeting schedule PDF generation service
https://pdf.code4recovery.org
MIT License
3 stars 2 forks source link

Add a "Default Unchecked" `Omit Page Numbering` Checkbox #26

Closed lloy0076 closed 2 years ago

lloy0076 commented 2 years ago

This would do what it suggests; it would effectively ignore the page number field entirely:

image

lloy0076 commented 2 years ago

Implement_'Omit_PageNumbering'.patch.txt

If the tickbox is unchecked it reverts to the current behaviour.

TBD. If this is accepted I wonder if we should make an empty value in Start # an error (which to me makes more sense - you don't start pages at null/empty values...)

lloy0076 commented 2 years ago

That patch implements it against:

commit bf2001988b90bbb4cec40865292bf5d040f7ee5b (HEAD -> main, origin/main, origin/HEAD)
Author: Josh Reisner <1551689+joshreisner@users.noreply.github.com>
Date:   Thu May 26 22:25:00 2022 -0700

    regions column support
joshreisner commented 2 years ago

you can actually omit page numbering by making the Start # field blank

lloy0076 commented 2 years ago

Yes, I know - and the problem there is that there's NOTHING that shows you can do that.

On 2022-06-29 4:43 pm, Josh Reisner wrote:

you can actually omit page numbering by making the |Start #| field blank

— Reply to this email directly, view it on GitHub https://github.com/code4recovery/pdf/issues/26#issuecomment-1170475203, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI6YBDLCKA2ROFKOH7LDMLVRSYPVANCNFSM52GBGHZA. You are receiving this because you authored the thread.Message ID: @.***>