search

code4recovery / pdf

Meeting schedule PDF generation service
https://pdf.code4recovery.org
MIT License
3 stars 2 forks source link

Support new language types #59

Closed anchovie91471 closed 7 months ago

anchovie91471 commented 8 months ago
anchovie91471 commented 7 months ago

It wasn't so much an advantage as I had problems getting headings to show up in the right font in the PDF (they would look fine in browser and then be Times New Roman when the PDF was output, whether Serif or Sans was chosen)

I honestly don't know why this was happening. It seemed a quirk of DOMPdF when loading custom fonts but only failed for the H1 and H3 tags. 🤷🏻‍♂️

It took a bunch of experimentation to get the right Serif font and the problems I was seeing could have been related to bad fonts. I can change them back and see what happens, but since a PDF was the final output, semantic HTML didn't seem important enough to worry about it.

joshreisner commented 7 months ago

yep, i agree, thanks!