code4recovery / tsml-ui

Embeddable recovery meeting finder
https://tsml-ui.code4recovery.org/
MIT License
23 stars 17 forks source link

Feedback form #252

Closed joshreisner closed 1 year ago

joshreisner commented 2 years ago

we have a stale branch for this: https://github.com/code4recovery/tsml-ui/tree/jr/feedback-form

in addition to the enhanced form, we may want to create a param to hook into TSML's email transport so that it's server-generated rather than client-generated

joshreisner commented 1 year ago

we have a stale PR for this: https://github.com/code4recovery/tsml-ui/pull/256 with i will re-sync with main, however i'm not 💯 sure this should move forward.

we recently improved TSML's feedback_url capabilities so groups may now link to a form plugin like gravity forms with all the fields filled out like enhanced feedback. this keeps the email logic and security out of TSML (which is where it would likely have to go, since React doesn't have email access natively)

kiyote33 commented 1 year ago

I'd like to see a demo on this. I quickly tried to get the feedback_url working in TSML with no joy. Maybe we could include that in our next meeting just so we are all on the same page. It may be we just need to improve documentation or do a How-To video so end-users aren't left in the lurch.

joshreisner commented 1 year ago

@kiyote33 sure here is a demo of where things stand now: https://deploy-preview-256--tsml-ui.netlify.app/tests/aasanjose.html?meeting=amor-y-tolerancia-2 - this netlify preview has an annoying bar at the bottom of the screen

we can set up a gravity forms demo on code4recovery.org - we do have some instructions here: https://wordpress.org/plugins/12-step-meeting-list/#can%20i%20set%20a%20custom%20%22update%20meeting%20info%22%20button%20in%20tsml%20ui%3F - this can been an opportunity to confirm they work

we are planning to discuss this in our meeting on the 28th

kiyote33 commented 1 year ago

Thanks Josh, I’ll dive into today.

I am just starting to refocus on C4R today after a gruelling 3 months building the new intergroup site for edmontonaa.org. Thanks for picking up the slack for me in the meantime.

Regards…

Wayne

From: Josh Reisner @.> Sent: January 17, 2023 10:10 AM To: code4recovery/tsml-ui @.> Cc: Wayne Parker @.>; Mention @.> Subject: Re: [code4recovery/tsml-ui] Enhanced feedback form (Issue #252)

@kiyote33 https://github.com/kiyote33 sure here is a demo of where things stand now: https://deploy-preview-256--tsml-ui.netlify.app/tests/aasanjose.html?meeting=amor-y-tolerancia-2 - this netlify preview has an annoying bar at the bottom of the screen

we can set up a gravity forms demo on code4recovery.org - we do have some instructions here: https://wordpress.org/plugins/12-step-meeting-list/#can%20i%20set%20a%20custom%20%22update%20meeting%20info%22%20button%20in%20tsml%20ui%3F - this can been an opportunity to confirm they work

we are planning to discuss this in our meeting on the 28th

— Reply to this email directly, view it on GitHub https://github.com/code4recovery/tsml-ui/issues/252#issuecomment-1385751684 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ANT2UM32NZK6IVN2CWH7QN3WS3G5VANCNFSM6AAAAAAQMUIB44 . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ANT2UMYGX4G5CSQ6GBCHGZLWS3G5VA5CNFSM6AAAAAAQMUIB46WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSSTDSII.gif Message ID: @. @.> >

joshreisner commented 1 year ago

closing this issue - not going to move forward. a frontend javascript project does not seem like a good place for a feedback form - that's better for some system that has access to the backend, like central