code4recovery / tsml-ui

Embeddable recovery meeting finder
https://tsml-ui.code4recovery.org/
MIT License
23 stars 17 forks source link

Phone Meetings Appear as inactive #291

Closed robanonservice closed 1 year ago

robanonservice commented 1 year ago

Hello, some of our phone meetings appear in active and we do not know why. Here's where our plugin is running.

This is an example of inactive phone meetings and not working as expected.

This is an example of a phone meeting that is currently working.

Attached please find a spread sheet which serves as our meeting feed. The first row represents a meeting that currently works -- the Hope and Serenity for Siblings of Alcoholics.

The rows underneath Hope and Serenity for Siblings of Alcoholics (row 2) represent phone meetings that the plugin on our website is showing as inactive.

Do you know what we are doing incorrectly for those phone meetings that are showing up as inactive?

phone problem - Sheet1.csv

joshreisner commented 1 year ago

hey @robanonservice i think i may have caused this recently by making an incorrect assumption. typically conference_phone numbers we see include 10 digits (for the base number in the USA) and then a few more for the room ID and or the password, so i recently started validating that we should see > 10 digits in a phone number.

looks like the meetings that are getting rejected are 10 digits. looks like at least some of these might be a free conference call "one number" https://www.freeconferencecall.com/onenumber

i'll adjust it to >= 10 which will fix these entries. also going to transfer this issue to TSML UI

joshreisner commented 1 year ago

ok should be fixed now. if i refresh https://www.nycalanon.org/meeting-directory.html?meeting=brooklyn-original-mon i see it is no longer inactive. thanks for the feedback!

FYI when you are formatting these, you may improve the link experience with these instructions: https://meetingguide.helpdocs.io/article/ydtd6y1ohn-how-to-add-online-meeting-information#google_sheet_or_custom_databases (i realize you're al-anon but the instructions are still valid for the web meeting finder)

robanonservice commented 1 year ago

thank you so much @joshreisner !

By the way, is there anyway for users of tsml to use it at a particular version instead of always loading the latest code?

joshreisner commented 1 year ago

yes. we only support the latest version, but technically you can reference a specific static version using the syntax https://cdn.jsdelivr.net/gh/code4recovery/tsml-ui@1.5.6/public/app.js (check out our releases for what version numbers to use)