code4recovery / tsml-ui

Embeddable recovery meeting finder
https://tsml-ui.code4recovery.org/
MIT License
23 stars 17 forks source link

Markers are projected into space 😅 #338

Closed tiptop96 closed 1 year ago

tiptop96 commented 1 year ago

After some of the recent updates we are experiencing an issue where markers kinda float on an axis. image (from: https://meetingfinderstorage.z13.web.core.windows.net/meetings.html?view=map) It is especially clear with a global view but is also apparent on a local scale (Swedish meetings hovering over Belarus). image (from: https://en.ca-sweden.se/moten?view=map) I tried looking through recent changes, read the readme and also I set map.style to one of the classic ones but projection remains weird.

Also we are receiving this warning: image However after loading the mentioned CSS the issue remains. This might be a separate issue but leaving it here for now.

Any idea what is going on?

joshreisner commented 1 year ago

hey i think you're right to look at the map style. in a recent update we bumped it from mapbox://styles/mapbox/streets-v9 to mapbox://styles/mapbox/streets-v12 - you should be able to set it back with your tsml_react_config variable

or also you might try playing around with the projection parameter. From the docs it says:

In the latest Mapbox styles, Globe is the default projection. (Streets, Outdoors, and Satellite Streets v12 and Light/Dark v11) In Navigation, Satellite, and earlier style versions the default is Mercator.

joshreisner commented 1 year ago

yah if you extend your tsml_react_config with

        map: {
          style: 'mapbox://styles/mapbox/streets-v10',
        },

it should go back to normal. i'll see if i can't fix the projection prop, but if i can't, then i'll make this the default soon

Screenshot 2023-11-03 at 10 30 50 AM
tiptop96 commented 1 year ago

Thanks, everything is looking great again! 🥳