code4rena-dev / components-library

Components library for Code4rena, and accessible as a package to be used in React based Code4rena products.
https://components-library-wine.vercel.app
0 stars 0 forks source link

Move fonts to reduce bundle size #19

Closed SamusElderg closed 11 months ago

SamusElderg commented 12 months ago

This might solve a large portion of #15 but we should leave the issue open to tackle this a little deeper even if it does

image

vercel[bot] commented 12 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
components-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 5:39am
SamusElderg commented 12 months ago

@leo95oliveira vercel isnt able to find the fonts in the public folder in the preview for some reason? This is specific to either vercel or storybook config as the build runs fine locally. Any ideas?

leo95oliveira commented 12 months ago

@leo95oliveira vercel isnt able to find the fonts in the public folder in the preview for some reason? This is specific to either vercel or storybook config as the build runs fine locally. Any ideas?

Looking at the build logs on vercel, I think the issue is pertaining to Storybook. I'm not 100% sure but I'll take a look later this afternoon and see what I can find!

SamusElderg commented 12 months ago

@leo95oliveira fixed the issue with storybook (it was an issue with how absolute urls are handled) if you review this and its all good, should we bundle it in with the v2.0.0 release?

leo95oliveira commented 12 months ago

@leo95oliveira fixed the issue with storybook (it was an issue with how absolute urls are handled) if you review this and its all good, should we bundle it in with the v2.0.0 release?

Legend! Looks great! Thank you for this! Yes, lets bundle it with v2!

SamusElderg commented 11 months ago

@leo95oliveira no rush, just checking if you intended to approve this one as your comments suggested you did but its still pending review 🙏