search

code4rena-dev / components-library

Components library for Code4rena, and accessible as a package to be used in React based Code4rena products.
https://components-library-wine.vercel.app
0 stars 0 forks source link

Fix some small bugs #22

Closed SamusElderg closed 12 months ago

SamusElderg commented 12 months ago

closes #21

vercel[bot] commented 12 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
components-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 4:34pm
SamusElderg commented 12 months ago

LGTM! 🚀 just switch the base branch from main to develop 😄

Done! Ill have to jump on a chat with you at some point so i can clarify best way to contribute to this repo 😂

leo95oliveira commented 12 months ago

LGTM! 🚀 just switch the base branch from main to develop 😄

Done! Ill have to jump on a chat with you at some point so i can clarify best way to contribute to this repo 😂

Hahaha sounds good, we can chat anytime! I need to write it in the README as well to make everyone's lives easier 😅

SamusElderg commented 12 months ago

Should be all good but ill just ask @leo95oliveira to confirm the target branch is good now? And id assume ill merge this one, then the avatar component one, then when we are ready we merge develop into main?

leo95oliveira commented 12 months ago

Should be all good but ill just ask @leo95oliveira to confirm the target branch is good now? And id assume ill merge this one, then the avatar component one, then when we are ready we merge develop into main?

Yes! Feel free to merge both! In terms of publishing to NPM once we merge develop to main, all the instructions are on the README, but feel free to reach out if you need any assistance 😄