code4rena-dev / components-library

Components library for Code4rena, and accessible as a package to be used in React based Code4rena products.
https://components-library-wine.vercel.app
0 stars 0 forks source link

Select / dropdown component #62

Open SamusElderg opened 6 months ago

SamusElderg commented 6 months ago

Just dropping this in as a reminder for myself to pad out, there are some iterations we should do with the select component including:

Edit Looks like it has something to do with onTouchStart if we remove that line completely everything appears to work as expected on desktop + mobile devices

SamusElderg commented 6 months ago

Just noticed (i added it to the issue above) that this dropdown doesn't appear to work on mobile devices, surprised it hasn't been reported by users yet? (maybe its specific to my device) but basically if you click the dropdown on mobile, it opens for a brief moment and then closes again, so you cant access the options in the dropdown

Keep in mind we may be doing a revamp of this component soon as lemongrass has been working on some designs that include a dropdown selector, so whilst we should fix this particular bug as priority, i wouldn't worry much about the list i was compiling in this issue