Make the test suite detect bugs

[javierm]

References

In order to make the customizations easier, we've brought the following changes from CONSUL:

• Pull request consul/consul#4707 (these tests were almost always failing on this repo)
• Pull request consul/consul#4715
• Pull request consul/consul#4755

Objectives

• Make sure the test suite detects bugs when we introduce them

[javierm]

07db690 Include Romanian language in the test environment I think, the second part of the message is no longer needed :thinking:

@Senen Thanks! I've updated it. At first I thought we could remove French and Dutch but of course they're there because they're actually used in the test suite :relieved:.

[javierm]

Hi, @decembrya :smile:.

Here's a missing the translation to English: "Verificându-vă informațiile veți avea acces la procesul de bugetare participativă". In case it helps, the key for this translation is verification.user_permission_info_budgets.

We've noticed the other texts we mentioned which lack an English translation aren't available in Romanian either. The missing texts are shown on this screenshot; they appear as "User Information", "Field", "Value", "Email", "Document Number" and "Phone Number" but note they are not the texts in English but placeholders automatically generated by the application. In this case, we'd need both the English and Romanian texts:

[javierm]

@decembrya Sorry for not noticing earlier :pray:. We've just found the original Romanian texts were accidentally removed in commit f86f48b16d. Are these texts OK? If so, we'd only need the English translations:

      user_information: "Informații despre utilizator (vizibile doar pentru administratori)"
      field: Câmp
      value: Valoare
      email: Email
      document_number: CNP
      phone_number: Număr de telefon

[javierm]

@decembrya Regarding the help page, we thought that (as is usually the case) the link to the help page was removed as a way to disable the help page completely. But, since there's a chance that the people in Brașov would like to enable this page without linking it from the homepage, we're keeping the current behavior and the link to the help page won't be displayed even if the feature is enabled :ok_hand:. We've made changes so it doesn't affect tests checking the presence of a "Help" link on the homepage when the feature is enabled.

[decembrya]

Hello @javierm, the translations you found are correct in Romanian, here are the English equivalents. Let me know if there are other translations needed.

  user_information: "Information about the user (visible only for administrators)"
  field: Field
  value: Value
  email: Email
  document_number: Document Number
  phone_number: Phone number

[decembrya]

For the help page, please let me know if you need further action from my side on the current installation. As I understand, it the page is not currently displayed or accessible except via a direct link so disabling it should not be an issue.

[javierm]

@decembrya Thanks! Could you also translate "Verificându-vă informațiile veți avea acces la procesul de bugetare participativă"? Only this one left :tada:.

P.S. No action regarding the help page is required from your side.

[decembrya]

Oh, sorry I missed that one, here is the translation: "By verifying your information you will gain access to the participatory budgeting process"

Thanks for clarifying on the help page 👍