code4romania / consul

Consul - Open Government and E-Participation Web Software
https://consulproject.org
GNU Affero General Public License v3.0
0 stars 4 forks source link

Improve budget investments form #43

Closed taitus closed 2 years ago

taitus commented 2 years ago

References

Requirement:

b. Form editing - We would like to be able to edit the Project proposal form, to add extra fields to it or to edit the existing ones

Objectives

The following is the breakdown of the requirements we will be applying:

  1. Add a new optional field to store the investment project author’s price estimation to the proposal form.
  2. Add empty hints for all the budget investment form fields.
  3. Show all those input hints in the admin section “Custom information texts” so the administrators can easily customize the text to show when necessary.

Visual Changes

taitus commented 2 years ago

@decembrya We have a question about where the "estimated price" field should be displayed once it has been filled in the form. Is this information only for administrators or should it also be displayed in the public investment details?

Right now we are showing it on both sides, as you can see from the "Visual changes" section in the description of the PR.

decembrya commented 2 years ago

It should be displayed publicly also. Right below the project description.

javierm commented 2 years ago

@decembrya This pull request is ready from our side. Could you review the texts we've added in Romanian (there's a huge chance our automatic translator returned non-sense in some cases)? If there's also a problem with certain English texts or any other part of this functionality, let us know as well :wink:.

By the way, we've added a new tab to the "custom information texts" section where administrators can now edit texts related to budgets. That way not only they can modify the hints in the investments form but any other text and they don't have to ask programmers to do so.

decembrya commented 2 years ago

Left some adjustments on the texts.

Great news about making the budget texts customizable! 👍