search

code4romania / covid-19-jurnal-medical

Centralization and monitoring of the state of people under auto-isolation with standardized questionnaires
https://dev.stamacasa.ro
Mozilla Public License 2.0
15 stars 52 forks source link

Cleanup #489

Closed Utwo closed 4 years ago

Utwo commented 4 years ago

Remove cypress Add titilium font-family Remove Terraform Add manifest.json Other small fixes

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/code4romania/stam-acasa/6lpmcpusn ✅ Preview: https://stam-acasa-git-fork-utwo-cleanup.code4romania.vercel.app

Utwo commented 4 years ago

I would propose to leave cypress in there. I believe it would encourage someone who want to start adding tests for the project. Does it affect the project in any way if we leave it there ?

It takes a lot of time to download the zip archive on npm install. In my opinion, we should not keep legacy code in repo because it will look intimidating for a newcomer and it will be harder to start working on the codebase. If in the future we will want to add cypress back, we will have the example in the git history.

RaduCStefanescu commented 4 years ago

This looks really nice, but I would like to postpone the merge for a bit, until we get version 1.0 launched.