code4romania / covid-19-ro-help

Platform for NGOs to create donation requests and to broadcast their services in an emergency
Mozilla Public License 2.0
18 stars 41 forks source link

City name isn't deleted from money need once changed #348

Closed catileptic closed 4 years ago

catileptic commented 4 years ago

Steps to reptoduce:

  1. Create an money need for an NGO in the dev env (for example, add a fake bank account)
  2. Assign an incorrectly spelled city to it
  3. Save
  4. In the city filter, you'll see the misspelled city appear
  5. Go back to the admin panel and change the city name to the correct spelling
  6. You'll notice that, in the cities drop-down, both city spellings are still present - the old one didn't get erased
  7. If you click the old city spelling in the city drop-down, the money need will still appear, even though the NGO has been configured to use the correct city spelling

The expected behaviour is that the old city spelling doesn't appear in the cities drop-down anymore, and that the money need doesn't appear attached to the old city spelling.