code4romania / covid-19-ro-help

Platform for NGOs to create donation requests and to broadcast their services in an emergency
Mozilla Public License 2.0
18 stars 41 forks source link

Selected option isn't displayed in the drop down for Urgenta #351

Closed codrutas1 closed 4 years ago

codrutas1 commented 4 years ago
  1. Open https://rohelp.ro/ro/?county=BACAU&city=Bac%C4%83u&urgency=medium Expected result: all the selected options should be displayed in drop downs Actual result: Moderate (or "medium"?) is not displayed in Urgenta Urgenta
catileptic commented 4 years ago

This is what your URL looks like on me. Can you make sure this issue reproduces?

Screenshot 2020-04-22 at 17 41 53

catileptic commented 4 years ago

(closed by mistake, I apologise)

codrutas1 commented 4 years ago

Hi, considering that for the other two drop downs the selected values remain displayed (e.g. Bacau is displayed in the first and second drop-down) shouldn't we see "Moderat" instead of "Urgenta" in the third one? If you select an option in the third dropdown, does it remain displayed for the user? For me, it looks like in the Actual Result section of the below image expected vs actual

catileptic commented 4 years ago

There was an Issue - though I can't seem to find it now - or a feature request to treat the urgency differently from the city. This is because seeing "Bacău" is self-explanatory - you can immediately assume that the list only displays needs form Bacău. However, seeing "Moderat" instead of "Urgență" cna be confusing to new users, because the word "Moderat" (or any of their others) on their own don't imply the concept of "urgency".

I'm closing this Issue for now. Please don't take it as an end to this discussion - if you feel that this is the wrong choice to make, re-open the issue and pursue the matter further. :)

codrutas1 commented 4 years ago

:) No worries, thank you for explaining.