search

code4romania / mon-vot-android-kotlin

Android election monitoring app - a mobile app through which commissioned observers can easily report back to their respective NGOs throughout the election day
https://votemonitor.org
Mozilla Public License 2.0
7 stars 29 forks source link

Fix RxJava null values usage #240

Closed lukstbit closed 4 years ago

lukstbit commented 4 years ago

What does it fix?

Closes #229

Instead of using null I created two alternative classes to represent errors in the streams.

@aniri A small heads up, the changes you made in #238 makes the app crash with FirebaseApp not initialized. I managed to get pass this by providing my own google-services.json file and applying the firebase and google services plugins.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

aniri commented 4 years ago

@lukstbit thanks for the heads up! I'll check it out :)