Open bvizureanu opened 6 years ago
Some of the following strings I believe that don't apply to all contexts so should be moved to the API, dynamic definition in the database Man/woman, rural/urban - that should depend on the country
<!-- Branch selection -->
<string name="branch_title">Choose the polling station</string>
<string name="branch_subtitle">you are in</string>
<string name="branch_county">County/District</string>
<string name="branch_number">Polling station number</string>
<string name="branch_change">Change the polling station</string>
<string name="branch_question_environment">Choose the area of the station</string>
<string name="branch_answer_rural">Rural</string>
<string name="branch_answer_urban">Urban</string>
<string name="branch_question_sex">The president of the polling station is:</string>
<string name="branch_answer_man">Man</string>
<string name="branch_answer_woman">Woman</string>
<string name="branch_question_enter">Arrival time</string>
<string name="branch_question_leave">Departure time</string>
<string name="branch_choose_time_enter">Choose the time of your arrival</string>
<string name="branch_choose_time_leave">Choose the time of your departure</string>
<string name="invalid_branch_county">Choose the county/district</string>
<string name="invalid_branch_number">Fill in the polling station number</string>
<string name="invalid_branch_number_minus">The number of the station must be positive</string>
<string name="invalid_branch_number_max">The maximum number for %1$s county is %2$s</string>
<string name="invalid_branch_environment">Choose urban of rural</string>
<string name="invalid_branch_sex">Choose man or woman</string>
<string name="invalid_branch_time_in">Select the time of arrival</string>
<!-- Forms list -->
<string name="form_1">Form A</string>
<string name="form_1_letter">A</string>
<string name="form_2">Form B</string>
<string name="form_2_letter">B</string>
<string name="form_3">Form C</string>
They are also hardcoded: https://github.com/code4romania/monitorizare-vot-android/blob/translations/app/src/main/java/ro/code4/monitorizarevot/adapter/SyncAdapter.java#L87-L89
See #38
County
to API or leave it here? I'd vote for moving it to API.