code4romania / monitorizare-vot-ios

iOS election monitoring app - a mobile app through which commissioned observers can easily report back to their respective NGOs throughout the election day
https://votemonitor.org/
Mozilla Public License 2.0
19 stars 24 forks source link

Project structure improvements #195

Open magyarosibotond opened 4 years ago

magyarosibotond commented 4 years ago

I've made some project structure improvements for a cleaner overview.

CristiHabliuc commented 4 years ago

Hey thanks for taking the time to do all this, we really appreciate it!

Until I get a deeper look into the actual changes, I wish you'd have done them in separate PRs, because some things we won't be changing. From first looks, these would still stay:

I'll checkout the PR tomorrow during the HackDay and get back with details. Thank you for the time put into this, some of these changes are really good!

magyarosibotond commented 4 years ago

Hey @CristiHabliuc!

Thanks for taking the time to go through the Pull request!

The overall purpose of the merge request was to add the same structure to the project on the filesystem level (with improvements here and there) as it is structured in the Xcode project. While doing that I've also removed some unused files and dependencies.

To answer your questions:

Since many files were moved it might be easier to check out the branch locally and review the changes there.