search

code4romania / monitorizare-vot-ong

NGO dashboard for viewing answers submitted by certified observers
https://votemonitor.org
Mozilla Public License 2.0
16 stars 44 forks source link

[Counties] View counties list #215

Closed aniri closed 3 years ago

aniri commented 4 years ago

Add a new page in the admin for managing counties and polling stations, it should be displayed in the header and called 'Polling stations'.

Backend part was implemented in https://github.com/code4romania/monitorizare-vot/issues/254 . The endpoint for viewing counties list is GET api/v1/county

UI available here: https://www.figma.com/file/61NHR7fwmV1Dsv4Pb6F8T7/code4ro_mv_user-management_2018.04.21-(Copy)?node-id=754%3A0

Functionality to be included:

For each county we should display the following columns in the table:

The counties should be sorted by the Order field.

Counties and polling stations

Please use bootstrap classes as much as possible and avoid adding custom css styles to keep the codebase clean & consistent. The new UI should be as similar as possible to the one in figma, not pixel perfect.

Also, make sure all texts are extracted in translation files.

dianapaula19 commented 4 years ago

Hi, could I please work on this issue?

aniri commented 4 years ago

Hi, could I please work on this issue?

@dianapaula19 sure! One thing to note though: we are working on making a UI makeover of the app (as you can see when you compare the current UI with the one from the figma link) and we are currently setting up a storybook with basic UI components to be reused in the project. So maybe we should split this issue so this one focuses mostly on functionality and make another issue for the UI. Or maybe we could hold on a bit until the storybook is properly set up so you could also add the new UI :smiley:

dianapaula19 commented 4 years ago

The second option sounds the best in my opinion, and it will also give me the opportunity to get more familiar with the project. :smiley_cat:

aniri commented 4 years ago

The second option sounds the best in my opinion, and it will also give me the opportunity to get more familiar with the project.

@dianapaula19 perfect :smiley:

aniri commented 4 years ago

@dianapaula19 we have decided to postpone creating the storybook and to go ahead with adding the new pages with the new UI :smile: So this issue is not blocked any more. I have also updated the description a bit to add more details. Thanks!

aniri commented 4 years ago

hey @dianapaula19 . we have just merged a huge refactoring PR, which also includes updating the bootstrap version. maybe it would be easier if you updated your branch also with the code from develop.

Botosio commented 3 years ago

@aniri is this still open? Would you want me to take a look?

aniri commented 3 years ago

@Botosio yep, it is still open. it would be great!

DeveloperDaveSDS commented 3 years ago

@aniri update. list works trying to implement some of the functions this morning.

... I can't add an image. 1 min

DeveloperDaveSDS commented 3 years ago

image

DeveloperDaveSDS commented 3 years ago

... I'm logged into my other account.

Botosio commented 3 years ago

@aniri can we create a story for the 2 actions in the table? Delete and Move to first?

The search is working on Country Name and Code

aniri commented 3 years ago

Wooooh, looks great :D

I updated this story https://github.com/code4romania/monitorizare-vot-ong/issues/221 to include the ordering related stuff. There might be some endpoints missing in the backend for this, but you could suggest the most convenient one when making the PR and I'll add the backend issue after that ;)

Also, we can skip the delete part for now and it does not make much sense at the moment to delete a county :)