Closed aniri closed 3 years ago
@aniri want me to take a look?
Also are we branching from upstream/develop or origin/develop? (If it matters?)
@aniri I'm not seeing any data coming back on this page. https://app.votemonitor.org/statistics - 500 error
@jrstrayhorn you have some time to take a look? It could be a server error.
@Botosio It might crash because there are no test data added and there's nothing to display now. I will check.
@Botosio - sure... I'll check it out too.
@Botosio @jrstrayhorn ok, found the issue and fixed it ;)
Also added some test data so there are some stats shown :D
You can also use the https://monitorizare-vot-ong-git-develop.code4romania.vercel.app/ as this is a bit more up to date than https://app.votemonitor.org .
As for the updates on statistics, the changes to be made are the following (as there might be some changes between current implementation and design):
"data": [
{
"label": "B",
"value": "1"
},
{
"label": "BH",
"value": "1"
},
{
"label": "CJ",
"value": "1"
}
],
I hope this clears things up a bit, as I noticed that the labels of the cards in the design do not match the ones in the implementation (which are in Romanian now :exploding_head: so probably confusing). Each card matches an API call.
Thanks!
@aniri new UI and dialog, please review code too I removed a lot!
Adapt the UI for the statistics page to make it as similar as possible to the one here https://www.figma.com/file/61NHR7fwmV1Dsv4Pb6F8T7/code4ro_mv_user-management_2018.04.21-(Copy)?node-id=754%3A0 under Reports.
Please use bootstrap classes as much as possible and avoid adding custom css styles to keep the codebase clean & consistent.
Also, make sure all texts are extracted in translation files.