[NGO Profile][Financial info] Financial data forms for 2023 doesn't appear for NGOs registered in 2023

code4romania / onghub

Mozilla Public License 2.0

5 stars 5 forks source link

[NGO Profile][Financial info] Financial data forms for 2023 doesn't appear for NGOs registered in 2023 #438

Open tudoramariei opened 5 months ago

tudoramariei commented 5 months ago

Describe the bug The /organizations/<org_id>/financial page should show the financial information of the NGO for the previous year. When the NGO registers, a set of forms appears for the previous year. Unfortunately, the NGOs registered in 2023 don't have the new set of forms generated. So, they are only left with the 2022 data.

Steps to reproduce the behavior

Log in to the admin interface
Go to /organizations/<org_id>/financial for an NGO registered in 2023
Look at the Financial data forms
Only the 2022 forms appear

Expected behavior The 2023 forms should also appear so the NGO can fill them out.

Screenshots Screenshot 2024-01-16 at 10 59 58

mirunaioana-msc commented 1 month ago

The expected behavior is:

on the 1st of January current year, 2 new entries should be generated in the financial data table corresponding with the previous (eg: on the 1st of January 2024 I shall have 2 entries for 2023 financial data)
on the 1st of June (or when it is scheduled in the system) current year, NGO HUB shall pull data from ANAF regarding the total expanses & income of the respective NGO. Then, the NGO will be able to edit the breakdown of the totals.

We need this because some NGOs already have the data available and can update their profile even before ANAF gets the statement from them.

radulescuandrew commented 3 days ago

@mirunaioana-msc There is an existing implementation to generate reports but was never added as a CRON job due to uncertainties regarding the exact date and the notification to be sent to NGOs.

A previous discussion mentioned to create them on 1st of June, even if ANAF may not publish the data until September/October.

We will set a Job to run on 1st of January and another one on 1st of June, with the mention that data may not be available. In this case should we send or not a notification to the NGO Admin to do the breakdown?