code4romania / onghub

Mozilla Public License 2.0
7 stars 5 forks source link

[SuperAdmin] Implement new labeling system for apps #495

Open mirunaioana-msc opened 4 months ago

mirunaioana-msc commented 3 months ago

Here I created a short design. Please see Figma here - https://www.figma.com/design/cfixQXmZ7FdFatiDCpUhyK/ONG-HUB?node-id=8672-19980&t=kcM88bkdIEWComoc-4

Basically I suggest adding in the creating/editing app page a section called App Status in which the SuperAdmin can choose if the app is active or not, where Active = available for NGOs to add on their profiles and Inactive = not available for NGOs to add in their profile + the SuperAdmin can add a label which can be put on the card app, without having these 2 (status and label dependent on each other). With the mention that an Inactive app should have this description on its page: "Aplicația este inactivă. Momentan, această aplicație nu este încă disponibilă. Vom reveni cu noutăți în curând." instead of the one suggesting that it is in development.

radulescuandrew commented 3 months ago

@andrei-manda Please clarify with @mirunaioana-msc regarding multi-select and display.

andrei-manda commented 3 months ago

Post Meeting Updates:

dragos1195 commented 3 months ago

As discussed in the meeting:

  1. Confirmed all of the above, that there is going to be a single select, with a predefined list that can be extended by the super-admin. We'll check the proper limit for the characters on the ribbon.

  2. The status of the application will be removed from the dropdown actions from the table and moved to the edit page, in order to generate consistency and avoid confusion between the texts ("dezactiveaza temporar" vs "inactiva")

  3. The "inactive" status will no longer display an "inactive app" ribbon. The label ribbon will be displayed regardless of the status of the application.

andrei-manda commented 3 months ago

Proposal

Issues

[FIXED] #### 1) 422 Unprocessable Content while retrieving NGOs applications Method: GET URL: application/organization/214 User: Super-Admin

The following error appears even for NGOs that has no application assigned.

image

[FIXED] #### 2) The label changes when the application is restricted to a specific NGO.

image

[FIXED] #### 3) There is some space left in the list when multiple options are available

image

[FIXED] #### 4) The way of removing the label is not intuitive; users must select the "Adauga opțiunea:" option, which can be confusing.

[FIXED] #### 5) The label text is not properly displayed when page is resized image

[FIXED] #### 6) The 'Eticheta pentru aplicatie' input is missing when creating a new application