search

code4romania / onghub

Mozilla Public License 2.0
7 stars 5 forks source link

fix 511: financial data error translations #573

Closed luciatugui closed 4 months ago

luciatugui commented 4 months ago

Regarding the ANAF endpoint subject of this issue, it seems that the actual problem is not the endpoint, but the fact the the CUI for the request does not exist.

ANAF does not return an error in this case, but we check further even if the req was successful to see if the data is synced. In case it is not synced, we show the error toast.

Question: should we enforce some sort of CUI validation on organisation creation?

stackblitz[bot] commented 4 months ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

tudoramariei commented 4 months ago

Question: should we enforce some sort of CUI validation on organisation creation?

Some sort of enforcement would be available if we used ANAF's endpoints. I left more details in this issue: https://github.com/code4romania/onghub/issues/574