search

code4romania / practice-for-good

Mozilla Public License 2.0
0 stars 2 forks source link

Issues with texts #53

Open tudoramariei opened 4 months ago

tudoramariei commented 4 months ago

Describe the bug

Some texts have not been finished (i.e., they contain lorem ipsums, missing diacritics, and use wrong names)

Screenshots

Screenshot 2024-03-04 at 15 39 02 Screenshot 2024-03-04 at 15 38 28 Screenshot 2024-03-04 at 15 55 17 Screenshot 2024-03-04 at 15 55 50
dragos1195 commented 1 month ago

@mirunaioana-msc please provide the correct texts, including diacritics.

mirunaioana-msc commented 1 month ago

Despre Practice for Good - https://www.figma.com/design/cfixQXmZ7FdFatiDCpUhyK/ONG-HUB?node-id=8202%3A2483&t=iQ5F2l0n0lbWmYFu-1

Pagina contact - https://www.figma.com/design/cfixQXmZ7FdFatiDCpUhyK/ONG-HUB?node-id=8206-18514&t=iQ5F2l0n0lbWmYFu-4

mirunaioana-msc commented 1 month ago

I can add missing diacritics if you give me a link to the json file

dragos1195 commented 1 month ago

Opened PR for issues in the description. For any other diacritics you can use the following JSON https://github.com/code4romania/practice-for-good/blob/main/src/assets/locales/ro/translation.json