[Refactor]: Bug smash session 1

moonflare commented 4 years ago

What changed?

Makes onClick callback optional for the button
Adds warning type for the button
Adds initial tab navigation for searchDropdown (We can navigate with tab, open the dropdown and select an item by pressing Enter)
Changes defaultValue selection and fixes some type errors for the Select component and adds deprecation message for the usage of options.selected field.
Change the Select input from uncontrolled to controlled.
Fixes some type errors for the input

ℹ️ Please note that there is a glitch for the deprecated option.selected version where the default value will be the first element in the options, and at the next render the default value is updated manually with the first option.selected = true.

TODO:

[x] Make the select component a controlled input instead of uncontrolled one

Actions (optional)

[x] Increase the version of the package if you need to release it after the merge
[x] ~If you added a new component, please make sure to export it in ../src/index.js~

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/code4romania/taskforce-fe-components/ee6d7ixkw ✅ Preview: https://taskforce-fe-components-git-dan-bug-smash-session-1.code4romania.now.sh

moonflare commented 4 years ago

~⚠️ Please hold reviews for this one. I need to implement backwards compatibility for the defaultValue changes in the select component.~

moonflare commented 4 years ago

The backwards compatibility and deprecation message for the select options.selected field have been implemented. Ready to be reviewed 👀

moonflare commented 4 years ago

We need to cover an extra use case for the Select component and therefore we need to refactor it from uncontrolled to controlled inputs.

code4romania / taskforce-fe-components