feat: SidebarMenu and Accordion components accesibility,

code4romania / taskforce-fe-components

reusable frontend components for taskforce projects

https://taskforce-fe-components.now.sh

Mozilla Public License 2.0

11 stars 34 forks source link

feat: SidebarMenu and Accordion components accesibility, #175

Closed andreibesleaga closed 4 years ago

andreibesleaga commented 4 years ago

What changed?

added SidebarMenu accesibility props added Accordion tabindex and hide/show on enter

(Make sidebar-menu-item component accessible for keyboard navigation #169) (Make accordion component accessible for keyboard navigation #170)

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/code4romania/taskforce-fe-components/hb405fhsq ✅ Preview: https://taskforce-fe-components-git-fork-andreibesleaga-master.code4romania.now.sh

surdu commented 4 years ago

Awesome to see a11y fixes coming to stam-acasa 🎉 ! Other than the ESLint issues, all looks good!

moonflare commented 4 years ago

Nice work @andreibesleaga. FYI. You can run npm run lint:fix to resolve the ESLint errors 🙌

aniri commented 4 years ago

closes #169 closes #170