code4romania / taskforce-fe-components

reusable frontend components for taskforce projects
https://taskforce-fe-components.now.sh
Mozilla Public License 2.0
11 stars 34 forks source link

Started using knobs #193

Open surdu opened 4 years ago

surdu commented 4 years ago

What changed?

Using Storybook Knobs in order to control variations on a component.

Actions (optional)

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/code4romania/taskforce-fe-components/i3xuuvka7
✅ Preview: https://taskforce-fe-components-git-feature-knobs.code4romania.vercel.app

surdu commented 4 years ago

Pros: You don't have to scroll to many instances of the same component in storybook: you have only one component with a UI to control all aspects of it.

Cons: Might not be as intuitive how to use the component looking at the storybook code

@moonflare , @Utwo Opinions? Before I start switching all components to use knobs :)

Utwo commented 3 years ago

I think it's more elegant with knobs but I don't know if it's worth the effort.

surdu commented 3 years ago

I don't know if it's worth the effort

too late 😅