Update devDependencies - Githubissues

code4romania / taskforce-fe-components

reusable frontend components for taskforce projects

https://taskforce-fe-components.now.sh

Mozilla Public License 2.0

11 stars 34 forks source link

Update devDependencies #196

Closed Utwo closed 4 years ago

Utwo commented 4 years ago

What changed?

Update all devDependencies. Close #194

Actions (optional)

[x] Increase the version of the package if you need to release it after the merge. This will bump to version 2.0.0
[ ] If you added a new component, please make sure to export it in ../src/index.js

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/code4romania/taskforce-fe-components/712tef2ky ✅ Preview: https://taskforce-fe-components-git-update-deps.code4romania.vercel.app

surdu commented 4 years ago

So... many... commas ... 😝

Utwo commented 4 years ago

So... many... commas ... stuck_out_tongue_closed_eyes

I think it's because of the eslint and prettier update. They changed the recommendation.

surdu commented 4 years ago

All those commas makes it very hard to review properly :( Can't we disable that rule? The rule is also not beneficial in my opinion.

cipick commented 4 years ago

Looks good for me