code4romania / taskforce-fe-components

reusable frontend components for taskforce projects
https://taskforce-fe-components.now.sh
Mozilla Public License 2.0
11 stars 34 forks source link

Add banner image #206

Closed cipick closed 3 years ago

cipick commented 3 years ago

What changed?

Actions (optional)

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/code4romania/taskforce-fe-components/l4kdyqwvb
✅ Preview: https://taskforce-fe-components-git-feature-banner-image.code4romania.now.sh

Utwo commented 3 years ago

A bit late to the party but we should set a width and a height for the image and a prop that will set target blank for the link.

aniri commented 3 years ago

@Utwo nice catch! added it as an issue https://github.com/code4romania/taskforce-fe-components/issues/207 ;)