code4romania / teacher-workout-android

Teacher Workout Android app
Mozilla Public License 2.0
5 stars 17 forks source link

Add dynamic features #18

Closed alexandru-calinoiu closed 3 years ago

alexandru-calinoiu commented 3 years ago

This is a proposal to split the app into feature modules, the main benefit in this case it will make the development easier as individual contributors can focus their effort on a individual feature and own it.

A brief explainer of the features can be found here

A brief explanation of the modules;

What does it fix?

Closes #XXX

How has it been tested?

lukstbit commented 3 years ago

@alexandru-calinoiu I have no experience with dynamic feature modules so I can't really comment on the code.

My understanding is that feature modules are related to on demand download from Google Play distribution which doesn't apply to our app(because it is small and we would get basically no benefit vs complexity). However, the navigation library doesn't seem to support normal modules and we kind of need to use feature modules if we use the navigation library.

AlexandraDamaschin commented 3 years ago

Merging this for now and will fix the improvements in another PR.