search

code4romania / teacher-workout-android

Teacher Workout Android app
Mozilla Public License 2.0
5 stars 17 forks source link

Add bottom navigation #35

Closed AlexandraDamaschin closed 2 years ago

AlexandraDamaschin commented 2 years ago

What does it fix?

Add bottom navigation https://developer.android.com/jetpack/compose/navigation#bottom-nav

Closes #XXX https://github.com/code4romania/teacher-workout-android/issues/29

How has it been tested?

Checked if the bottom nav bar appears on home/discover/profile screens

AlexandraDamaschin commented 2 years ago

@lukstbit let me know if you have any thoughts on this. Thanks in advance :)

AlexandraDamaschin commented 2 years ago

I've connected the bottom nav bar to the implemented profile screen. If there are any other improvements on this PR let me know, otherwise we can merge it. cc @lukstbit @alexandru-calinoiu

lukstbit commented 2 years ago

@AlexandraDamaschin Looks good. In the app module's build file we still reference the profile module which we agreed to be used from home. So we should remove:

implementation(project(BuildModules.Features.PROFILE)) from app/build.gradle.kts to be explicit about this.

AlexandraDamaschin commented 2 years ago

@catileptic could you help me with approving this PR so we can merge it? Thanks :)