code4romania / vic

Mozilla Public License 2.0
2 stars 2 forks source link

[Login] Can not correct login data once they are identified as wrong #232

Closed monikozi closed 1 month ago

monikozi commented 1 year ago

Description

Mobile [Volunteer Login] Can not correct login data once they are identified as wrong

Test environment

Android

Preconditions

In the mobile app from Inregistrare screen: Create a Volunteer account with Email1 and Phone1 Logout

Test Data

Two email accounts and two phone numbers

Steps of Reproduction

Create a Volunteer account with Email2 and Phone1 In the Account creation screen, the phone is validated as duplicate The user can not edit the phone number Press back and land on the Inregistrare screen Create a Volunteer account with Email2 and Phone2 A message informs the user that the email is already in use Return to Inregistrare > Autentifica-te using the Email2 account and password Land on Create account form

Expected Result

Expected result: the phone number to be editable

Actual Result

Actual result: The phone number is read only

Notes (optional)

n/a

Screenshots (optional)

https://github.com/code4romania/teo/assets/64305252/9f93e94f-a518-4ce8-9cc2-de49fe199101

theavitw commented 1 year ago

I can do this. iy should be assign to me.

andrei-manda commented 2 months ago

Steps to Reproduce:

  1. Access the mobile app
  2. Click on the 'Email sau telefon' button (in order to create a new account)
  3. Complete the form with valid data using the following phone number: 761351509
  4. Insert the verification code received on email
  5. Complete the 'Date utilizator' form and send it

Expected Result:

  1. The duplicate phone number error is displayed, allowing the user to edit it

Actual Result:

  1. The phone number input is disabled

Notes:

birloiflorian commented 1 month ago

@andrei-manda @mirunaioana-msc This issue is due to cognito allowing phone number duplicates. As is now i have enabled the user to change the phone number from the registration screen and will sync it with cognito once the profile is updated. Also this should happen if the user changes the phone number from settings as well.