search

code4romania / vic

Mozilla Public License 2.0
2 stars 2 forks source link

[Volunteer profile] Admin can't edit volunteer profile from web-side #247

Open anastk-code4 opened 10 months ago

anastk-code4 commented 10 months ago

Description

As an AdminONG user, I tried to fill in profile details for a newly joined volunteer, and could not save it.

Test environment

Web

Preconditions

Test Data

Steps of Reproduction

Expected Result

Actual Result

Notes (optional)

Screenshots (optional)

dragos1195 commented 10 months ago

@anastk-code4 @radulescuandrew

Cannot reproduce this from WEB app (v0.12.11), while being logged in as an Admin. Voluntiari -> Select a volunteer - Tap editeaza on Informatii Voluntar -> Can edit every single information successfully.

Could you help with a video?

anastk-code4 commented 10 months ago

WEB app (v0.12.11) Steps to reproduce:

  1. As a mobile user, I requested to join this NGO.
  2. From web side, logged in as AdminONG for that NGO, I approved the join request.
  3. mobile user did not complete their profile in the mobile app, not even once accessed it (this is a possible scenario). (AdminONG user wants to set up their volunteer profile from web side, independently from the mobile user).
  4. As AdminONG, I can see the new volunteer in the volunteers list
  5. see video: https://github.com/code4romania/teo/assets/95479576/86e0e6b8-5317-486d-933f-9e371c619f50
radulescuandrew commented 10 months ago

@anastk-code4 Got it now. It works as intended, there is no profile to be updated by the Admin. To improve the experience, we can disable the editing possibility or display a flag like "User has no profile".

@overeha please advise.

anastk-code4 commented 6 months ago

in this case, when volunteer user did not create their profile, Web user should be able to create volunteer's user profile (not just edit an already created profile), because there is a frequent use case for this