[Do NOT Merge] Upload/View host ID document support for accommodation/housing offer forms

[mail4taz]

Requirements for making a pull request

Thank you for contributing to our project!

Please fill out the template below to help the project maintainers review it as fast as possible and include your contribution to the project.

What does it fix?

Closes #155

Please mention the main changes this PR brings.

This is WIP as 1st we need to validate the proposed approach. Final solution needs to consider answers to https://github.com/code4romania/war-support-un-acoperis/issues/155#issuecomment-1059980055

• new AccommodationAttachment class added to support generic attachments
• new model re-uses existing "accommodation-photos" table and adds new "doc-type" integer field to it
• AccommodationPhoto and AccommodationPhotoId child classes extend AccommodationAttachment
• provided support to upload 1 file for AccommodationPhotoId when creating housing offer by a host
• provided support to view the AccommodationPhotoId on the housing offer by the host and admin user
• needs migration SQL for the changes on "accommodation-photos" table

How has it been tested?

Please describe the tests that you ran to verify your changes.

• local testing using local storage
• create&view new housing offer by host
• view housing offer by admin

[beniamin]

You can mark de PR as draft to avoid accidentally merging.

When your work is ready you can mark it as "Ready for review". More info here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request

[andreiio]

@mail4taz Thanks for your contribution! Continuing the conversation from the issue here.

1. does it make sense to be on the Offer Housing screen instead of the My Account section? How is this ID linked to the housing offer? If it's gonna be the ID of user who is responsible for the refugees during the stay, it would make sense to have 1 ID for all housing added in the platform by the same user. If we are expecting to be the ID of the house owner then yes, most likely we need to have 1 offer ~ 1 ID uploaded.

Good point! The ID should be linked to user and not to the accommodation, so it has to be uploaded in step 2. Create an account. It should also be possible to upload an ID from the admin dashboard, when creating a new host user.

2. If the answer to prev question is 1 ID per 1 housing offer, can that ID by edited during the Edit housing offer screen?

Not applicable anymore.

3. what type of ID's will we be allowing. As far as I understand we won't run any automated validation checks, but there should be a minimal description, like "upload a photo of your CI or passport". So what type of documents can a user add - passport / driving license / CI?

Until I can get confirmation on what documents are allowed, the label should read "Upload your ID" for persons and "Upload your CUI" for companies.