search

code4sac / codeforsacramento.org

Pull requests welcome!
http://codeforsacramento.org
MIT License
16 stars 28 forks source link

Adding docker compose support #76

Closed feydan closed 1 year ago

feydan commented 1 year ago

Using docker-compose to reduce install steps

natebass commented 1 year ago

I believe docker compose v2 has dropped docker-compose in favor of docker compose.

The compose command in the Docker CLI supports most of the docker-compose commands and flags. It is expected to be a drop-in replacement for docker-compose. https://docs.docker.com/compose/cli-command-compatibility/

I went through this change before with @shollingsworth on trash-ai. It worked fine when we tested on the spot, but it doesn't look like the changes have been implemented in the production branch https://github.com/code4sac/trash-ai/blob/5c834573f3ceb79396078444d7d5d887e6bf1ff6/localdev/Makefile. If there are no issues we should go forward with docker compose.

feydan commented 1 year ago

Thanks for the feedback @natebass , I'll give docker compose a shot and update the readme if it works out for me.