search

code4sac / opensac.org

Pull requests welcome!
https://opensac.org
MIT License
3 stars 13 forks source link

Add a linter and linting rules #61

Open feydan opened 2 months ago

feydan commented 2 months ago

We want to make sure that all developers contributing to the code base save code in the same format so our IDEs don't fight each other on superficial formatting like spaces and newlines.

Alisa1989 commented 1 month ago

how about this one: dbaeumer.vscode-eslint

feydan commented 1 month ago

how about this one: dbaeumer.vscode-eslint

Yep this extension for vs code is good, but we will also need an eslint file in the repo, and maybe some instructions in the readme for using this extension.

I think we should also use Prettier and the extension for that too. And also https://github.com/prettier/eslint-config-prettier#installation.

Alisa1989 commented 1 month ago

looks like there is a way that Next wants us to do things: linting in Next.js There is also a section explaining how to use ESLint in conjunction with Prettier I'll have a look into it next week.

Alisa1989 commented 3 days ago

The linter works now and I removed initial errors with a commit. The next commit will be to adjust the img tags to Image but it will be quite laborious as the width property needs to be modified. https://stackoverflow.com/questions/75781160/next-image-component-gives-error-missing-required-width-property-when-runni