code4sac / sacramento-campaign-finance

Dataset and dashboard of money in local politics
https://sacramento-campaign-cash.netlify.app/
2 stars 5 forks source link

Change aggregation and remove SQLite from ETL pipeline #23

Closed jeremiak closed 1 year ago

jeremiak commented 1 year ago

Hope to close out #18 when this gets merged. This PR:

netlify[bot] commented 1 year ago

Deploy Preview for sacramento-campaign-cash ready!

Name Link
Latest commit 26c39deff0c9961744fa77d43950c130c9eac864
Latest deploy log https://app.netlify.com/sites/sacramento-campaign-cash/deploys/65123d3f7dfdb5000828ca82
Deploy Preview https://deploy-preview-23--sacramento-campaign-cash.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jeremiak commented 1 year ago

Cool, I agree that it's best to keep them separate for now (especially since they're pretty small functions) so that the amount of stuff a developer needs in their head when they make changes is minimized. At least until we have much higher/better test coverage. Which shouldn't be hard, we currently have 0% coverage.