code4sac / sacramento-campaign-finance

Dataset and dashboard of money in local politics
https://sacramento-campaign-cash.netlify.app/
2 stars 5 forks source link

Remove nvmrc file #32

Closed natebass closed 1 year ago

natebass commented 1 year ago

Pull request 25 (https://github.com/code4sac/sacramento-campaign-finance/pull/25) adds tabler as an npm dependency. It requires node v18, whereas our application nvmrc specified v16.

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@tabler/core@1.0.0-beta20',
npm WARN EBADENGINE   required: { node: '>=18' },
npm WARN EBADENGINE   current: { node: 'v16.20.1', npm: '8.19.4' }
npm WARN EBADENGINE }

I think we should remove the .nvmrc file to increase simplicity of the file structure. We could also update the file to a more recent version of node.

Let me know what you all think. Thanks.

netlify[bot] commented 1 year ago

Deploy Preview for sacramento-campaign-cash ready!

Name Link
Latest commit 2f86905eb7fd429fc450c53b021c4a1d55f73aa1
Latest deploy log https://app.netlify.com/sites/sacramento-campaign-cash/deploys/6527acd77ade300008d32981
Deploy Preview https://deploy-preview-32--sacramento-campaign-cash.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

natebass commented 1 year ago

OK, sounds good.

I updated the file to Node 18.

jeremiak commented 1 year ago

Nice! Refs #26