search

code4sac / wicit

A simple node/express app for finding locations that accept WIC in California, using data from the new California Department of Public Health open data portal.
http://findwic.com/
MIT License
19 stars 20 forks source link

Search Page: Initial implementation #30

Closed donmccurdy closed 9 years ago

donmccurdy commented 9 years ago

Here's where I'm at so far:

screen

I haven't used Angular all that much, would the different states (before search, pending, showing results, etc.) normally be split into different partials? Wondering how that should work.

About style.css – I tried Sass 3.4.9 as well and it kept doing the same thing.. really strange. For now I'm just avoiding the long diff on style.css by using the 'compressed' option in grunt-contrib-sass, since https://github.com/code4sac/wicit/issues/21 is open: wasn't sure if you were going to want the minified resources version-controlled after that anyway.

jesserosato commented 9 years ago

@donmccurdy sorry for the delay in getting to this, work and what not. I'm not sure if you'd want to break up the different states into separate partials, because I believe each one incurs an HTTP request to retrieve it. I think if you can sensibly write the markup with those sub-states in a single partial that's probably the way to do it. Again, I'm no Angular expert, so I'm very open to more ideas/info on how to do that.

As for the Sass stuff, not sure what's going on there. You're right that the minified resources should not be in source, and it looks like #31 fixes that, nice.

Thanks again for your contribs, and sorry for the delay in pulling this in.

donmccurdy commented 9 years ago

Awesome, and no worries on any delays I'm in no particular rush. :)

So far #31 only cuts the minified JS but that's a really good point. Should be easier now to keep minified CSS out of source too, with a separate grunt prod task.