code8825 / arduino

Automatically exported from code.google.com/p/arduino
Other
0 stars 0 forks source link

Arduino Ethernet needs tailored pins_arduino.h and IDE needs to us it #925

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. write a script including use of LED_BUILTIN for example:
Serial.write( "LEDBUILTIN: ");Serial.println(LED_BUILTIN); 
2. from the IDE, select Tools, board, Arduino Ethernet, compile, upload, run.

expected:LEDBUILTIN: 9
actual: LEDBUILTIN: 13

Using Arduino 1.01 on Mac OSX lion with Arduino Ehternet Board.

This is a trivial example of a much bigger problem, specifically that the 
Arduino Ethernet board needs a pins_arduino.h tailored for it.

Attached is a version derived from current .../variants/standard/pins_arduino.h 

The IDE needs to use this version, perhaps from the .../variants/ethernet 
directory when the Arduino Ethernet Board is selected.

Original issue reported on code.google.com by jaguar3s...@gmail.com on 28 May 2012 at 7:13

Attachments:

GoogleCodeExporter commented 9 years ago
Looks good.

Are there other changes besides the LED_BUILTIN.  If there aren't many, it 
might be better to have the ethernet pins_arduino.h just include the standard 
one and then change the relevant #define's (if that's possible).  See 
eightanaloginputs for an example.

Original comment by dmel...@gmail.com on 29 May 2012 at 3:16

GoogleCodeExporter commented 9 years ago
Sorry for the delay in response, I don't check my gmail often(and I was
wondering why you hadn't responded!)

There are more changes that just LEDBUILTIN.
I think that adding conditional/parameterized  defines would be more
complicated and confusing rather than just selecting a specific "BOARD"
from the IDE dropdown.

Original comment by jaguar3s...@gmail.com on 3 Jul 2012 at 10:44

GoogleCodeExporter commented 9 years ago
Added the variant. Thanks.

https://github.com/arduino/Arduino/issues/925
C

Original comment by c.mag...@arduino.cc on 3 Nov 2013 at 1:02