search

codeAdrian / gatsby-omni-font-loader

Font loader optimized for maximum performance. Removes render-blocking font resources and loads them asynchronusly. Handle FOUT & FOUC with font loading status watcher. Supports both local-hosted fonts and web fonts.
MIT License
106 stars 7 forks source link

Feature Request: Remove usage of `react-helmet` #32

Open LekoArts opened 2 years ago

LekoArts commented 2 years ago

Hi!

With Gatsby 4.19 a Head API was released: https://www.gatsbyjs.com/docs/reference/release-notes/v4.19/#gatsby-head-api

I'm slowly removing react-helmet from all my projects and replace it with the Head API. To be able to completely remove that react-helmet dependency this plugin would need to not rely on react-helmet.

While you can't use Gatsby Head API for your plugin, you can use the normal setHeadComponents API. Or did you run into any problems when using that and opted for react-helmet? :)

Happy to help with guidance on how to remove that peerDep.

Thanks!

codeAdrian commented 2 years ago

Hi Lennart. Thanks for the heads up. I've haven't been following Gatsby's development in the past few months, but I'm happy to improve the plugin if needed. I'm away on holiday for the next 10 days, hopefully I'll be able to pick this up once I'm back. I'll let you know if I run into any issues.

LekoArts commented 2 years ago

Awesome, enjoy your vacation :)

duffner commented 2 years ago

Hi @codeAdrian, I'm seeing if you have had any chance to look at this. I've been a super happy user of this plugin, and I'm migrating all of my code away from React Helmet and moving towards the native Gatsby head approach and I'm hoping to see this move in the more modern direction as well ;)

Cheers! Thanks for a great product

RectoVersoDev commented 1 year ago

Same as @duffner here 👍

AndriiChubariev commented 1 year ago

Hi, same here!

yvonnetangsu commented 1 year ago

Another +1 - using Gatsby v5 and would love to remove react-helmet 👍🏼

SkyRousse commented 1 year ago

another plus 1