Improve Command Line and add validation. v3.0

[codeBelt]

41

31

[krambono]

I found some "problems" that I had fixed in my previous closed pr.

• If you don't use the overwrite flag, even if the files don't exist, it will throw an error
• If you define many times the same string replacer in command line, it doesn't work
• Errors that are throwed are not catch and sometimes the program break with the "UnhandledPromiseRejectionWarning" which is a deprecated behavior

[codeBelt]

@knona Thanks for the feedback.

• Fixed the issue with file not writing even if they don't exist.
• Addressed the UnhandledPromiseRejectionWarning issue and cleaned up how errors are displayed.

I don't understand the following. It should display an error if the command line has the same string replacers in command line and not work.

• If you define many times the same string replacer in command line, it doesn't work

The user should see this error:

[krambono]

We talked about that with @ccheney. We could imagine that we take the last value defined of the string replacer. To me, both behavior are correct.

I readed your last commit. I saw you use the process.exit() function. Why don't you catch the errors with a try / catch ?

From what I know using the exit function is not recommended.

[codeBelt]

Ok, I changed the process.exit() to a try/catch. Thanks @knona for reviewing this.

[codeBelt]

We could imagine that we take the last value defined of the string replacer.

@knona to make things easier we should just error and have the user fix their mistake then trying to fix it for them.

[krambono]

We could imagine that we take the last value defined of the string replacer.

@knona to make things easier we should just error and have the user fix their mistake then trying to fix it for them.

I agree.