search

codeRIT / brickhack.io

The public-facing marketing site for BrickHack
https://brickhack.io/
38 stars 30 forks source link

BrickHack 8 Site - About Section #1254

Closed sjmiller7 closed 2 years ago

sjmiller7 commented 2 years ago

Fixes #1248

Had to remove prizes cards since we technically don't know if we have prizes yet.

At the time of posting, I am waiting on Design to fix the bar underneath the rickies. I might talk to them Monday (12/6) about switching to gifs for quality, since the video here is also fuzzy. Might need to do some analysis of gif file size vs quality upgrade.

skyegallup commented 2 years ago

rip netlify :pensive:

peterkos commented 2 years ago

One thing we can tackle later is the extra padding in the right card due to less content compared to the left card. Can prob fix with some filler text

sjmiller7 commented 2 years ago

less padding here?

See design's Figma. That is specified.

maybe shift this section up a bit?

See design's Figma. That is specified. Moving it up would push it to flex-start and create a ton of whitespace underneath.

Numbers can be bigger

Last update I made to number styling was doing the code in front of design team and asking what they liked. They specifically approved what is in there now.

If there are issues to be had with what design team is specifying, I recommend pinging them about it in #design channel. I am inclined to go with whatever they say.

Can prob fix with some filler text

Not really sure what you mean here. It would be something to bring up with marketing in the general pr. Generally, we should want our content to be concise for ux/skimming purposes, not verbose for aesthetic purposes.

peterkos commented 2 years ago

Apologies for being a bit out of the loop; as with the numbers changing from the figma, I wasn't 100% on if the spacing was also as intentional.

Can prob fix with some filler text Not really sure what you mean here. It would be something to bring up with marketing in the general pr.

Yea, that's what I mean -- would be good to talk w/ Adam on adding some filler as an alternative to modifying the design itself

LGTM

skyegallup commented 2 years ago

I agree with @sjmiller7 that it's not a great idea to add unnecessary or unnecessarily verbose text just to eliminate whitespace. Content > styling