search

codeSessionsP2 / masimapage

masima landing page
MIT License
1 stars 2 forks source link

Hover Cross Device #6

Open mxklb opened 8 years ago

mxklb commented 8 years ago

Actually hover is used for front/back flipping effect. This shall be changed to be cross plattform, onclick, touch whatever, must work ...

smnwndrr commented 8 years ago

This issue is also addressed in my repo, please test: http://smnwndrr.github.io/masimapage/

mxklb commented 8 years ago

Commits or branches should be tagged with issue IDs. Doing this should avoid such "pointless" comments and simply link src changess to the corresponding issue. Just pointing me to the result of your gh-pages branch did not help me much, sorry .. A clearly linked SCM change (commit or better a separate branch) would have done this better ..

sorry, but we're actually not that confirm with github, but I've already saw this SCM changes to corresponding issues of other projects. Check out: http://stackoverflow.com/questions/1687262/link-to-github-issue-number-with-commit-message

smnwndrr commented 8 years ago

Sorry, next time. I don't know if changing a commit message ist possible, but i can refer to the commit: 430e8957ff8e1eac6a7a23679e496b696944078f

mxklb commented 8 years ago

we should try using #issuenumber within commit messages, this should directly link changes. I believe doing so gh directly shows diffs as issue comments which is quite handy. Next time...

Actually providing the hash is enough for me now, good night!

mxklb commented 8 years ago

worse a review:

https://help.github.com/articles/closing-issues-via-commit-messages/

mxklb commented 8 years ago

By the way this issue is now in review. I think we should try out some devices latest sources ..

mxklb commented 8 years ago

Could you please test yours and some friend phones for the hover (and mobile touch) if it is working correctly? It would be nice to get some feedback. We should also try Sebs crappy windows phone ..

Finally the audio issue #5 has some kind of similar issue according to onclick js on the play buttons.

mxklb commented 8 years ago

just view my gh-pages result: http://mxklb.github.io/masimapage/ for testing purpose ..

mxklb commented 8 years ago

This may get obsolete if we decide to remove hover completely. In the actual layout and animation design on-click/touch shall be all we need. Maybe source code still contains hover artefacts, so I'll leave this one open till we reviewed and maybe got rid of this s*\

mxklb commented 8 years ago

By the way actually hover on the ticker stops the ticker movement animation.

This could be removed within #25 as well (tbd)