search

codeaffen / phpipam-ansible-modules

Ansible Modules to manage phpIPAM installations
https://codeaffen.org/projects/phpipam-ansible-modules
GNU General Public License v3.0
22 stars 10 forks source link

Add parameter for l2domain to `subnet` module #85

Closed cmeissner closed 2 years ago

cmeissner commented 2 years ago

Is your feature request related to a problem? Please describe.

Another thing to consider is that when adding a subnet to a VLAN then in the GUI it shows the different l2 domains, but when using the ansible modules, currently the l2 domain can not be specified and it will choose randomly, which l2 domain it picks.

Originally posted by @TafkaMax in https://github.com/codeaffen/phpipam-ansible-modules/issues/84#issuecomment-1221949152

Describe the solution you'd like

To solve this task it becomes necessary to add a domain parameter to our subnet module. This parameter needs to be mandatory after implementing #84. It should also defaulted to default as in vlan module.

Describe alternatives you've considered

For the while we don't have such a parameter we provide default l2domain as default for resolving vlans. In that case multi domain vlans are not supported.

Additional context

Simply adding the parameter with default should be enough but we need to be aware that this parameter should never presented to API as it is not supported. 

$ rg api_invisible
plugins/modules/location.py
134:            resolv_location=dict(type='bool', required=False, default=False, api_invisible=True),

plugins/modules/address.py
140:            section=dict(type='str', api_invisible=True, required=True),

plugins/module_utils/phpipam_helper.py
276:            if key in self.phpipam_params and not spec.get('api_invisible', False):
305:            'api_invisible',
314:            'api_invisible',