Shortened Hash ID is irregular Length

codeamp / circuit

CodeAmp API. Built with Golang, GraphQL, GORM and Socket-IO

Apache License 2.0

21 stars 6 forks source link

Shortened Hash ID is irregular Length #351

Closed aballman closed 5 years ago

aballman commented 6 years ago

Describe the bug Commit IDs are referenced in Circuit in a 'shortened form' with a total of 7 characters. In panel, and on git, shortened commit hashes are represented with 8 characters.

Circuit should match the rest of the world.

aballman commented 5 years ago

Turns out circuit is correct. Panel should be showing 7 not 8. I've updated the slack notifier plugin to present URLs with 7 characters so panel just needs to be updated.