codeamp / circuit

CodeAmp API. Built with Golang, GraphQL, GORM and Socket-IO

Apache License 2.0

21 stars 6 forks source link

Fix schema.graphql errors for Import/Export related functions #423

Closed drshrey closed 5 years ago

drshrey commented 5 years ago

The environmentID was absent for importSecrets and the userID can be derived from context as opposed to the user having to pass it in (which makes the userID attribute unnecessary). This PR adds in the environmentID and removes the userID. The unit tests do not cover the validity of the GraphQL schema, so this was missed in those tests. In the future, I'll have to compensate for that with a more manual testing process or incorporating schema validity into our automated tests.

codecov[bot] commented 5 years ago

Codecov Report

Merging #423 into master will decrease coverage by 0.1%. The diff coverage is 40%.

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   61.42%   61.32%   -0.11%     
==========================================
  Files          51       51              
  Lines        5247     5256       +9     
==========================================
  Hits         3223     3223              
- Misses       1709     1715       +6     
- Partials      315      318       +3