codeamp / circuit

CodeAmp API. Built with Golang, GraphQL, GORM and Socket-IO
Apache License 2.0
21 stars 6 forks source link

Add 'must be general type' condition if creating ports in createService #426

Closed drshrey closed 5 years ago

drshrey commented 5 years ago

We should only create ports if it makes sense to do so i.e. when the Service type can make use of the exposed ports. In this case, only general services allow port creation. This enforces that condition in the mutation

codecov[bot] commented 5 years ago

Codecov Report

Merging #426 into fix-yaml-tags-services will increase coverage by 0.02%. The diff coverage is 100%.

@@                    Coverage Diff                    @@
##           fix-yaml-tags-services    #426      +/-   ##
=========================================================
+ Coverage                   61.28%   61.3%   +0.02%     
=========================================================
  Files                          51      51              
  Lines                        5256    5259       +3     
=========================================================
+ Hits                         3221    3224       +3     
  Misses                       1717    1717              
  Partials                      318     318