codeamp / circuit

CodeAmp API. Built with Golang, GraphQL, GORM and Socket-IO
Apache License 2.0
21 stars 6 forks source link

Add "project" scope when importing secrets #428

Closed drshrey closed 5 years ago

drshrey commented 5 years ago

In ImportSecrets, the scope is not explicitly defined, so the scope is a blank string. This leads the Secrets() query to pull it since it is looking for secrets that don't have "project" defined as the scope, including blank strings. This means we show these secrets on the Admin/Secrets page which is undesired.

Fix: add "project" scope when creating a secret.

codecov[bot] commented 5 years ago

Codecov Report

Merging #428 into master will increase coverage by 0.04%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
+ Coverage    61.3%   61.34%   +0.04%     
==========================================
  Files          51       51              
  Lines        5259     5260       +1     
==========================================
+ Hits         3224     3227       +3     
+ Misses       1717     1715       -2     
  Partials      318      318