Add release env - Githubissues

codeamp / circuit

CodeAmp API. Built with Golang, GraphQL, GORM and Socket-IO

Apache License 2.0

21 stars 6 forks source link

Add release env #446

Closed zhouzhuojie closed 5 years ago

zhouzhuojie commented 5 years ago

Add KUBE_POD_RELEASE_ENV, I'm not sure if FieldPath: "metadata.labels.environment" can get the environment or not.

amoskyler commented 5 years ago

This looks alright to me. Can I get a second confirm on that @drshrey?

zhouzhuojie commented 5 years ago

@drshrey do you know why circleci is pending?

aballman commented 5 years ago

@drshrey do you know why circleci is pending?

@zhouzhuojie Its because we didn't previously enable circleci to build forked branches. I've enabled that now so if you push a noop it should run.

zhouzhuojie commented 5 years ago

@aballman

No CODECLIMATE_REPO_TOKEN found. A CODECLIMATE_REPO_TOKEN must be specified as an environment variable.
Exited with code 1

CircleCI for public forks cannot access some private env variables.

zhouzhuojie commented 5 years ago

@aballman
No CODECLIMATE_REPO_TOKEN found. A CODECLIMATE_REPO_TOKEN must be specified as an environment variable.
Exited with code 1
CircleCI for public forks cannot access some private env variables.

Since it's already open source, and code climate supports it, https://codeclimate.com/oss/, do we need a private token here?